refactor(AsideHeader): asideHeader rewrited to hooks #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
DarkGenius
requested changes
Sep 18, 2023
|
|
||
| interface AsideHeaderContextType { | ||
| compact: boolean; | ||
| export interface AsideHeaderContextType extends AsideHeaderInnerProps { |
There was a problem hiding this comment.
This context is not intended to drag all the props into it, since it is exported outside. Let's try to explicitly pass props whenever possible, or create a separate context for internal use
catakot
force-pushed
the
refactor/AsideHeader
branch
from
4560c61 to
23c7b19
Compare
DarkGenius
reviewed
Sep 19, 2023
| menuItems: MenuItem[]; | ||
| headerDecoration: boolean; | ||
| } | ||
| import {FirstPanel} from './components'; |
There was a problem hiding this comment.
Let's move the imports above the style imports
|
Action Item in compact mode is broken 
|
Lunory
reviewed
Sep 19, 2023
Lunory
approved these changes
Sep 20, 2023
DarkGenius
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.